Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy: add connection limits metrics #16718

Merged
merged 1 commit into from
Feb 9, 2024
Merged

envoy: add connection limits metrics #16718

merged 1 commit into from
Feb 9, 2024

Conversation

wdauchy
Copy link
Contributor

@wdauchy wdauchy commented Jan 28, 2024 •
edited
Loading

see also
https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/network_filters/connection_limit_filter

  • Add envoy connection limits metrics
  • unit test
  • changelog
  • Update metadata.csv
  • adapt stat_prefix behaviour to 1.29
    see also envoyproxy/envoy@ea71e73

statsd:

connection_limit.ingress_http.active_connections: 0
connection_limit.ingress_http.limited_connections: 0

prometheus (legacy):

# TYPE envoy_connection_limit_ingress_http_limited_connections counter
envoy_connection_limit_ingress_http_limited_connections{} 0
# TYPE envoy_connection_limit_ingress_http_active_connections gauge
envoy_connection_limit_ingress_http_active_connections{} 0

prometheus (>= 1.29):

# TYPE envoy_connection_limit_limited_connections counter
envoy_connection_limit_limited_connections{envoy_connection_limit_prefix="ingress_http"} 0
# TYPE envoy_connection_limit_active_connections gauge
envoy_connection_limit_active_connections{envoy_connection_limit_prefix="ingress_http"} 0

@ghost ghost added the integration/envoy label Jan 28, 2024
@wdauchy wdauchy force-pushed the william.dauchy/0 branch 5 times, most recently from adb5e71 to d19e13e Compare January 28, 2024 14:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited
Loading

Test Results

  6 files    6 suites   2m 30s ⏱️
 94 tests  92 ✅  2 💤 0 ❌
285 runs  258 ✅ 27 💤 0 ❌

Results for commit 62125de.

♻️ This comment has been updated with latest results.

@wdauchy wdauchy force-pushed the william.dauchy/0 branch 17 times, most recently from 1f15e82 to a7aaab2 Compare February 2, 2024 14:15
@wdauchy wdauchy force-pushed the william.dauchy/0 branch 2 times, most recently from 9fab1aa to 42513c4 Compare February 8, 2024 09:25
@wdauchy wdauchy mentioned this pull request Feb 9, 2024
Merged
@wdauchy wdauchy force-pushed the william.dauchy/0 branch 3 times, most recently from 87b76c4 to 5d5029f Compare February 9, 2024 17:00
@wdauchy wdauchy force-pushed the william.dauchy/0 branch 3 times, most recently from b4e6bce to 18abf96 Compare February 9, 2024 18:07
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d09e63e) 90.40% compared to head (62125de) 90.52%.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
envoy 95.15% <100.00%> (+0.37%) ⬆️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@wdauchy wdauchy force-pushed the william.dauchy/0 branch 2 times, most recently from 084f027 to 2ce9e80 Compare February 9, 2024 18:31
@wdauchy wdauchy marked this pull request as ready for review February 9, 2024 18:32
@wdauchy wdauchy requested a review from a team as a code owner February 9, 2024 18:32
@wdauchy wdauchy force-pushed the william.dauchy/0 branch 2 times, most recently from f489bdb to 972f2dc Compare February 9, 2024 18:39
@wdauchy wdauchy force-pushed the william.dauchy/0 branch 2 times, most recently from 99ffd5e to 34e44fe Compare February 9, 2024 18:49
@wdauchy
envoy: add connection limits metrics
62125de 
see also
https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/network_filters/connection_limit_filter

- Add envoy connection limits metrics
- unit test
- changelog
- Update metadata.csv
- adapt stat_prefix behaviour to 1.29
  see also envoyproxy/envoy@ea71e73

Signed-off-by: William Dauchy <[email protected]>

fix metric map
@wdauchy wdauchy requested a review from steveny91 February 9, 2024 19:02
@steveny91 steveny91 merged commit 304488d into DataDog:master Feb 9, 2024
35 checks passed
Kyle-Neale pushed a commit that referenced this pull request Feb 12, 2024
@wdauchy @Kyle-Neale
envoy: add connection limits metrics (#16718)
37e9753 
see also
https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/network_filters/connection_limit_filter

- Add envoy connection limits metrics
- unit test
- changelog
- Update metadata.csv
- adapt stat_prefix behaviour to 1.29
  see also envoyproxy/envoy@ea71e73

Signed-off-by: William Dauchy <[email protected]>

fix metric map
NouemanKHAL pushed a commit that referenced this pull request Mar 4, 2024
@wdauchy @NouemanKHAL
envoy: add connection limits metrics (#16718)
66e5d3e 
see also
https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/network_filters/connection_limit_filter

- Add envoy connection limits metrics
- unit test
- changelog
- Update metadata.csv
- adapt stat_prefix behaviour to 1.29
  see also envoyproxy/envoy@ea71e73

Signed-off-by: William Dauchy <[email protected]>

fix metric map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanduncandatadog seanduncandatadog seanduncandatadog left review comments

@steveny91 steveny91 steveny91 approved these changes

@henrymwang henrymwang henrymwang approved these changes

Assignees
No one assigned
Labels
integration/envoy team/agent-integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wdauchy @henrymwang @steveny91 @seanduncandatadog