Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect state to OMv2 and shadow prefix tag to legacy #16453

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Dec 18, 2023

What does this PR do?

Add a metric that was collected in Legacy that wasn't ported over to OMv2. Also add the ability for rbac metric to have a optional tag for shadow_rule_prefix

@ghost ghost added the integration/envoy label Dec 18, 2023
Copy link

github-actions bot commented Dec 18, 2023

Test Results

    6 files      6 suites   2m 17s ⏱️
  92 tests   90 ✔️   2 💤 0
279 runs  253 ✔️ 26 💤 0

Results for commit 69f07bd.

♻️ This comment has been updated with latest results.

@steveny91 steveny91 marked this pull request as ready for review December 18, 2023 22:07
@steveny91 steveny91 requested a review from a team as a code owner December 18, 2023 22:07
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #16453 (69f07bd) into master (3b35b09) will increase coverage by 0.09%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
envoy 95.01% <100.00%> (+0.27%) ⬆️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 merged commit 23d60a3 into master Dec 19, 2023
41 checks passed
@steveny91 steveny91 deleted the sy/envoy-connected-metric branch December 19, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants