Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: add local rate limit metrics #16313

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

wdauchy
Copy link
Contributor

@wdauchy wdauchy commented Nov 30, 2023

What does this PR do?

  • Add envoy local rate limit metrics
  • unit test
  • changelog
  • Update metadata.csv

see also https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/local_rate_limit_filter#config-http-filters-local-rate-limit

Motivation

local rate limit metrics are missing in datadog

@ghost ghost added the integration/envoy label Nov 30, 2023
Copy link

github-actions bot commented Nov 30, 2023

Test Results

    6 files      6 suites   2m 15s ⏱️
  91 tests   89 ✔️   2 💤 0
276 runs  250 ✔️ 26 💤 0

Results for commit b736a12.

♻️ This comment has been updated with latest results.

@wdauchy wdauchy force-pushed the william.dauchy/1 branch 8 times, most recently from 67f0986 to 6fe666e Compare November 30, 2023 11:46
- Add envoy local rate limit metrics
- unit test
- changelog
- Update metadata.csv

see also https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/local_rate_limit_filter#config-http-filters-local-rate-limit

Signed-off-by: William Dauchy <[email protected]>
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #16313 (b736a12) into master (7a60ac6) will increase coverage by 3.42%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
Flag Coverage Δ
envoy 95.18% <100.00%> (+0.50%) ⬆️
hudi ?
ignite ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@wdauchy wdauchy marked this pull request as ready for review December 6, 2023 18:07
@wdauchy wdauchy requested a review from a team as a code owner December 6, 2023 18:07
@steveny91 steveny91 mentioned this pull request Dec 6, 2023
@FlorentClarret FlorentClarret added this to the 7.51.0 milestone Dec 7, 2023
@FlorentClarret FlorentClarret merged commit 5c2a71d into DataDog:master Dec 7, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants