Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support histograms, fix count submission #1616

Merged
merged 7 commits into from
May 30, 2018
Merged

support histograms, fix count submission #1616

merged 7 commits into from
May 30, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented May 28, 2018

What does this PR do?

This adds support for histograms to the Envoy integration.

Additional Notes

During debugging I noticed Envoy counts are monotonically increasing and therefore corrected the submission method.

@ofek ofek added this to the 6.3 milestone May 28, 2018
@ofek ofek changed the title support histograms support histograms, fix count submission May 28, 2018
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@ofek ofek merged commit b2a9e4c into master May 30, 2018
@ofek ofek deleted the ofek/envoy-histograms branch May 30, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants