Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Profiles support #14752

Merged
merged 20 commits into from
Jun 19, 2023
Merged

Add User Profiles support #14752

merged 20 commits into from
Jun 19, 2023

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jun 14, 2023

This PR tests requires this PR to be merged DataDog/datadog-agent#17395

What does this PR do?

User profiles folder support is added to python SNMP integration for backward compatibility.

Related corecheck implementation here: DataDog/datadog-agent#17395

The Python implementation is as minimal as possible, it doesn't include:

  • Handling of precedent of user sysObjectID when the same sysObjectID is already present in corecheck. In Python implementation duplicate sysObjectID is not allowed across user profiles and default_profiles.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ghost ghost added the integration/snmp label Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Test Results

    3 files      3 suites   13m 6s ⏱️
257 tests 186 ✔️     1 💤 70
593 runs  186 ✔️ 337 💤 70

For more details on these failures, see this check.

Results for commit d1af276.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #14752 (d1af276) into master (52e0386) will increase coverage by 0.02%.
The diff coverage is 79.26%.

❗ Current head d1af276 differs from pull request most recent head bff6740. Consider uploading reports for the commit bff6740 to get more accurate results

Flag Coverage Δ
snmp 82.27% <79.26%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlexandreYang AlexandreYang changed the title Separate user and default profiles Add User Profiles support Jun 15, 2023
@AlexandreYang AlexandreYang marked this pull request as ready for review June 15, 2023 13:42
@AlexandreYang AlexandreYang requested a review from a team as a code owner June 15, 2023 13:42
@AlexandreYang AlexandreYang requested a review from a team as a code owner June 15, 2023 13:42
@AlexandreYang AlexandreYang merged commit e79c81a into master Jun 19, 2023
@AlexandreYang AlexandreYang deleted the alex/user_profiles branch June 19, 2023 16:39
aquiladayc added a commit that referenced this pull request Jun 28, 2023
remove lines

Update CHANGELOG.md

Draft CHANGELOG.md

Update metadata.csv

Update metadata.json

Update conftest.py

Update CHANGELOG.md

Remove change log

Update ecs_fargate.py

Add __init__ function

Fix ecs_fargate.py and add tests

Add new performance counter metrics (#14625)

* Add new cluster metrics

* Add host and VM metrics

* Add realtime fixtures

* update metadata.csv

* Add throughput metric

Move cancel waiting logic to test functions for DBMAsyncJob  (#14773)

* init commit

* revert changes to sqlserver, mysql, utils tests

Add validations for removed dependencies (#14556)

* Map out new licenses validation

* Implement validations for extra licenses

* Add constants to config.toml

* Implement license validation

* Uncomment legacy licenses validation

* Keep license command addition in same place

* Small style change

* Update config.toml override values

* Refactor

* Fix style

* Apply suggestions from code review

Co-authored-by: Ofek Lev <[email protected]>

* Update suggestions

* Require CI for license validation tests and update to use empty envvars

* Fix permission for file

* Add windows version of setting github env vars

* Fix windows file

* Change to powershell script

* Output GITHUB_ENV on windows CI

* Convert entirely to powershell

* Change back to bat file

* Test DD_GITHUB_USER value

* Print github user in license test

* Manually set Github user and token in test

* Fix config_file

* Print github user

* Check if tokens are the same

* Remove additional space in bat script

* Fix style and remove test code

* Change order of scripts

* Try commenting out model.github override

* Revert previous commit

* Change to threads instead of async

* Switch out async request to requests

* Clean up

* Fix style

---------

Co-authored-by: Ofek Lev <[email protected]>

DOCS-5656 gke setup links to operator/helm (#14746)

dbm-oracle-dashboard (#14736)

Internally compile the `include` patterns in the autodiscovery feature (#14768)

* Internally compile the `include` patterns in the discovery feature

* address

Use Git for versioning (#14778)

Upgrade Pydantic model code generator (#14779)

* Upgrade Pydantic model code generator

* address

build standalone binaries for ddev (#14774)

Remove `pyperclip` dependency and clipboard functionality (#14782)

[Release] Bumped datadog_checks_dev version to 20.0.0 (#14784)

* [Release] Bumped datadog_checks_dev version to 20.0.0

* [Release] Update metadata

Bump the minimum version of datadog-checks-dev (#14785)

update license path (#14783)

Allow all projects to be collected in REST implementation (#14433)

* Bug Fix Teamcity rest with all projects

* .

Rewrite Postgres size query and add `postgresql.relation.{tuples,pages,all_visible}` + toast_size metrics (#14500)

* Bumped dependency version

* Rewrite size metric query

Use new query executor
Split toast size from table size
Add partition_of tag
Add pages/tuples/allvisible metrics
Optimise query to minimise stat calls

* Add partitioned test tables

* Update metadata with new metric

* Fix version check

* Fix wal_level for tests

[SNMP] Add metadata for traps telemetry metrics (#14769)

* Add metadata for traps telemetry metrics

* Remove commas from desc 🤦‍

* Add units

Temporarily disable py2 tests on PRs (#14793)

fix(redisdb): return len of stream instead of 1 (#14722)

Currently the code compute the len of the stream but report always 1

This change fixes this.

Update Netflow dashboard (#14794)

* update Netflow dashboard

* remove datadog_demo_keep:true

* avg -> sum

* rename dashboard

revert manifest.json (#14797)

Add User Profiles support (#14752)

Remove Content (#14766)

Update wording and add extra install directions for ODBC (#14781)

* Update wording and add extra install directions for ODBC

* Update README.md

Add ability to choose tag to append to VM hostname (#14657)

* Add ability to choose tag to append to VM hostname

* Add a test for integration tags

* Sort list

* Change log to debug

* Fix style

* Allow user to choose a datadog tag for vm hostname

Fix ability to release ddev (#14790)

Disable server info and version collection when collect_server_info is false (#14610)

* if collect_server_info is set to false disable server info and version collection

* the collect metadata in check.py has to check for the collect_server_info before attempting to collect server info, even when the base url is well formated

* add testing to see if metadata is collected when collect_server_info is false

* add testing to see if metadata is collected when collect_server_info is false

* fix typo

* fix typo

* commit

* commit

* commit

* commit typo

* fix check.py

[Release] Bumped datadog_checks_dev version to 20.0.1 (#14806)

* [Release] Bumped datadog_checks_dev version to 20.0.1

* [Release] Update metadata

[Release] Bumped ddev version to 3.0.0 (#14807)

* [Release] Bumped ddev version to 3.0.0

* [Release] Update metadata

fix build flake for ddev (#14808)

Fix ddev platform installers and releasing (#14812)

Bump postgres integration to Python 3 (#14813)

update changelog generation (#14810)

Update ecs_fargate/tests/fixtures/metadata_v4.json

Co-authored-by: Cedric Lamoriniere <[email protected]>

Update ecs_fargate/tests/fixtures/stats_linux_v4.json

Co-authored-by: Cedric Lamoriniere <[email protected]>

Update test_unit_v4.py

Update license term

Update test_unit_v4.py

update license format

Update metadata.csv

Fix unit name

Set the `marker` option to `not e2e` by default (#14804)

Add profile for hp-ilo (#14771)

* add profile for hp-ilo

* add tests for new hp-ilo profile

* fix linter

* hp-ilo4 extends hp-ilo

* delete unnecessary product_name field

* lint

* move hp-ilo to default-profiles

Update profiles with missing devices (#14695)

* update cisco-asr

* update cisco-catalyst-wlc

* update cisco-catalyst

* update cisco-legacy-wlc

* update cisco-nexus

* update dell-poweredge

* update juniper-ex

* update juniper-mx

* add cisco-isr

* add models + move cisco5700WLC to cisco-catalyst-wlc

* move cisco-isr to default-profiles

Add profile 3com-huawei (#14694)

Revert "Set the `marker` option to `not e2e` by default (#14804)" (#14815)

This reverts commit 3f4c885.

Sort assert_device_metadata tags (#14816)

Add per vendor generic profiles (#14721)

* add dell generic profile

* add fortinet generic profile

* add juniper generic profile

* move vendor profiles to default-profiles

* add test for cisco

* add test for dell

* add test for fortinet

* add test for juniper

* linter

* linter

Update formatting for changelogs (#14814)

* Update formatting for changelogs

* Update formatting for changelogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants