[Unified Instance Tagging]: Add cloud_metadata to DBM event payloads #14312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
The |
alexandre-normand
previously approved these changes
Apr 5, 2023
iliakur
previously approved these changes
Apr 6, 2023
5 tasks
alexandre-normand
dismissed stale reviews from iliakur and themself
via
c224454
This reverts commit c224454.
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
alexandre-normand
approved these changes
Apr 13, 2023
yzhan289
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
cloud_metadatafields to all DBM event payloads, this adds necessary context in order link DBM event data with related cloud resource data in our backend.The goal here is to allow customers to filter event data by a new universal tag
database_instance, which will be applied across DBM and cloud telemetry.