Add missing metrics #14036
Merged
Add missing metrics #14036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
FlorentClarret
force-pushed
the
florentclarret/envoy/duplicate-metrics
branch
from
36f4a6e to
2903475
Compare
FlorentClarret
force-pushed
the
florentclarret/envoy/duplicate-metrics
branch
from
2903475 to
b505d3d
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
FlorentClarret
force-pushed
the
florentclarret/envoy/duplicate-metrics
branch
2 times, most recently
from
d2d3c2d to
9425ab0
Compare
FlorentClarret
force-pushed
the
florentclarret/envoy/duplicate-metrics
branch
from
9425ab0 to
36892a8
Compare
alopezz
approved these changes
Feb 28, 2023
| @@ -108,7 +108,6 @@ | |||
| 'envoy_cluster_upstream_rq_rx_reset': 'cluster.upstream_rq_rx_reset', | |||
| 'envoy_cluster_upstream_rq_time': 'cluster.upstream_rq_time', | |||
| 'envoy_cluster_upstream_rq_timeout': 'cluster.upstream_rq_timeout', | |||
| 'envoy_cluster_upstream_rq': 'cluster.upstream_rq', | |||
There was a problem hiding this comment.
A bit surprised by this one, I would expect some linting rule to catch this (duplicate dict key) 🤔 .
There was a problem hiding this comment.
To be honest, I missed that one too, my IDE linter caught it 😅
Edit: Seems like flake8 does not catch this kind of errors if the values are identical: https://flake8.pycqa.org/en/5.0.4/user/error-codes.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.