Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ext_authz metrics to envoy integration #12374

Merged

Conversation

Kaycell
Copy link

@Kaycell Kaycell commented Jun 16, 2022

What does this PR do?

I've observed we are missing metrics from envoy ext_authz http filters. Documentation
Also the failure_mode_allowed is missing for the rate limit filter even the other metrics are present Documentation

Motivation

Gathering a broader set of metrics

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@Kaycell Kaycell requested a review from a team as a code owner June 16, 2022 11:44
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #12374 (2f2dda8) into master (f245e7c) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
envoy 94.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants