Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix only_custom_queries configuration not honored #11506

Merged

Conversation

alexandre-normand
Copy link
Contributor

What does this PR do?

This fixes support for the only_custom_queries. Prior to this change, all core mysql metrics were still emitted even with only_custom_queries set to true.

Motivation

A customer report.

Additional Notes

performance_schema is being used by the statement metrics job loop when dbm is enabled. Previously, this was gathered with other global status variables in the main metric collection but this had to be extracted now to always be initialized regardless of whether the core integration metrics were collected or not.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@alexandre-normand alexandre-normand added integration/mysql category/bugfix For use during Agent Release period labels Feb 15, 2022
@alexandre-normand alexandre-normand requested review from a team as code owners February 15, 2022 20:14
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #11506 (742af40) into master (e89bb02) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 87.75% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alexandre-normand alexandre-normand added changelog/Fixed and removed category/bugfix For use during Agent Release period labels Feb 15, 2022
alexbarksdale
alexbarksdale previously approved these changes Feb 16, 2022
Copy link
Member

@alexbarksdale alexbarksdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mysql/datadog_checks/mysql/mysql.py Outdated Show resolved Hide resolved
@alexandre-normand alexandre-normand merged commit fa2346f into master Feb 17, 2022
@alexandre-normand alexandre-normand deleted the alex.normand/mysql-honor-only_custom_queries-config branch February 17, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants