Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description of jmx options #10454

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Fix description of jmx options #10454

merged 4 commits into from
Oct 20, 2021

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Oct 20, 2021 •
edited
Loading

What does this PR do?

tools_jar_path and process_name_regex require the tools.jar file, which was removed in Java 9: https://openjdk.java.net/jeps/220. This PR updates the descriptions to note this change.

Motivation

Support case

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@yzhan289 yzhan289 requested a review from a team as a code owner October 20, 2021 17:52
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #10454 (b02e988) into master (6a548c1) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 requested a review from a team as a code owner October 20, 2021 18:25
@yzhan289 yzhan289 changed the title Fix description of jmx option Fix description of jmx options Oct 20, 2021
fanny-jiang
fanny-jiang requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@fanny-jiang fanny-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit regarding the spelling and wording. My suggestion would apply for all the changed checks

activemq/datadog_checks/activemq/data/conf.yaml.example Outdated Show resolved Hide resolved
activemq/datadog_checks/activemq/data/conf.yaml.example Outdated Show resolved Hide resolved
@yzhan289 yzhan289 requested a review from fanny-jiang October 20, 2021 19:08
fanny-jiang
fanny-jiang approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@fanny-jiang fanny-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd also wait to hear from @DataDog/documentation on any feedback.

ruthnaebeck
ruthnaebeck approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@yzhan289 yzhan289 merged commit 106a41a into master Oct 20, 2021
@yzhan289 yzhan289 deleted the az/tools-jar-update branch October 20, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/activemq integration/cassandra integration/confluent_platform integration/datadog_checks_dev integration/hazelcast integration/hive integration/hivemq integration/hudi integration/ignite integration/jboss_wildfly integration/kafka integration/presto integration/solr integration/sonarqube integration/tomcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yzhan289 @ruthnaebeck @fanny-jiang @ChristineTChen