Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes_state] fix missing columns in metadata.csv #1195

Merged
merged 2 commits into from
Mar 13, 2018

Conversation

chotiwat
Copy link
Contributor

@chotiwat chotiwat commented Mar 5, 2018

What does this PR do?

This pr fixes some rows with a missing column in metadata.csv.

Motivation

I was looking at the file to see the available metrics and saw GitHub warning about the mismatch in the number of columns.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

GitHub editor automatically added a newline at the end of file. I hope that doesn't break the parser.

@chotiwat chotiwat changed the title fix missing columns in metadata.csv [kubernetes_state] fix missing columns in metadata.csv Mar 5, 2018
@chotiwat
Copy link
Contributor Author

chotiwat commented Mar 5, 2018

I'm not sure if I should bump the version or not since 2.3.0 is unreleased.

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump, good to go!

@masci masci merged commit 25d381e into DataDog:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants