Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mesos Slave] Check available metrics for backwards compatibility #1066

Merged
merged 6 commits into from
Jan 29, 2018

Conversation

dixonscottr
Copy link
Contributor

@dixonscottr dixonscottr commented Jan 29, 2018

What does this PR do?

Before submitting a metric, adds a check to ensure the metric exists in the dict returned when querying the /metrics/snapshot endpoint.

Motivation

The check was failing for versions < 1.0.0, since GPU metrics are only available since version 1.0.0

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

This replicates the logic found in the mesos_master check

@dixonscottr dixonscottr changed the title [Mesos Slave] Check if metric exists before submitting [Mesos Slave] Check available metrics for backwards compatibility Jan 29, 2018
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dixonscottr dixonscottr merged commit 3255b73 into master Jan 29, 2018
@dixonscottr dixonscottr deleted the scottdixon/mesos_metrics branch January 29, 2018 16:21
@hush-hush hush-hush added this to the 5.22 milestone Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants