Test

aerospike/datadog_checks/aerospike/aerospike.py

@@ -170,21 +170,6 @@ def check(self, _):
 
         self.service_check(SERVICE_CHECK_UP, self.OK, tags=self._tags)
 
-    def collect_xdr(self):
-        # TODO: get list of datacenters. dcs command is deprecated
-        if self._required_datacenters:
-            for dc in self._required_datacenters:
-                data = self.get_info('get-stats:context=xdr;dc={}'.format(dc))
-                datacenter_tags = ['datacenter:{}'.format(dc)]
-                for item in data:
-                    tags = ['datacenter_host:{}', 'datacenter_port:{}']
-                    metric = item.split("=")
-                    key = metric[0]
-                    value = metric[1]
-                    self.send(DATACENTER_METRIC_TYPE, key, value, tags)
-        else:
-            self.log.debug("No datacenters to collect XDR metrics from")
-
     def collect_version(self):
         try:
             raw_version = self.get_info("build")[0]
@@ -243,6 +228,22 @@ def get_datacenters(self):
 
         return datacenters
 
+    def collect_xdr(self):
+        # TODO: get list of datacenters. dcs command is deprecated
+        if self._required_datacenters:
+            for dc in self._required_datacenters:
+                datacenter_tags = ['datacenter:{}'.format(dc)]
+                pass
+                # data = self._run_command('get-stats:context=xdr;dc={}'.format(dc))
+                # for item in data:
+                #     tags = ['datacenter_host:{}', 'datacenter_port:{}']
+                #     metric = item.split("=")
+                #     key = metric[0]
+                #     value = metric[1]
+                #     self.send(DATACENTER_METRIC_TYPE, key, value, tags)
+        else:
+            self.log.debug("No datacenters were specified to collect XDR metrics: %s", self._required_datacenters)
+
     def get_client(self):
         client_config = {'hosts': [self._host]}
         if self._tls_config: