Skip to content

Commit

Permalink
relax MEMORY_USAGE_THRESHOLD in test to account for slightly increase…
Browse files Browse the repository at this point in the history
…d mem from tracing (#18890)

* reset peak before trace mem

* increase test mem threshold to account for additional mem from trace

* add comments
  • Loading branch information
lu-zhengda authored Oct 23, 2024
1 parent ffeba1e commit 43e34f8
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ def test_compute_derivative_rows_mem_usage(self):
Make sure we minimize the temporary objects created when computing the derivative
This test is skipped if tracemalloc is not available
'''
MEMORY_USAGE_THRESHOLD = 7 * 1024 * 1024 # 7 MB
# The memory usage threshold takes tracing overhead into account
MEMORY_USAGE_THRESHOLD = 8 * 1024 * 1024 # 8 MB

try:
import tracemalloc
Expand Down

0 comments on commit 43e34f8

Please sign in to comment.