enforce code covereage on every run and with low overhead #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had to remove gemspec from Gemfile or the file would be uncovereage since it is loaded before coverage starts
|
ready to merge |
grosser
commented
Feb 3, 2018
Gemfile
Outdated
|
|
||
| gem 'rake', '10.1.0' | ||
| gem 'rack', '~> 1.6' | ||
| gem 'minitest' | ||
| gem "yard", "~> 0.8.7.3" | ||
| gem 'simplecov' | ||
| gem 'jeweler', '~> 1.8' |
There was a problem hiding this comment.
jeweler should go away
|
otherwise looks right! :) |
|
@grosser thanks, going to release soon and ship allthethings |
|
got a few more PRs :)
…On Sat, Feb 3, 2018 at 2:52 PM, Massimiliano Pippi ***@***.*** > wrote:
Merged #75 <#75>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAsZ6u80gdSuCRXEXsEi7X1jjdvBfRVks5tROMhgaJpZM4R4NbX>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes 2 of my other PRs, so needs a rebase before it can be merged
Error looks like this:
@masci