Allow tags as hashes #107
Merged
Allow tags as hashes #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. Is there anything I can do to make this easier to merge? I'm happy to sign CLA. I hereby license this code under the MIT licence (the same as this library). And/or whatever other licence might make it easier to integrate. |
|
I was just about to start a PR on this and then saw yours! Thanks @jtzemp |
|
Hi @jtzemp! Sorry we didn't review this in 6 months... 🙁 The patch looks good and the change makes a lot of sense, so merging! Thanks a lot for your contribution (and your patience) 😀 |
pudiva
pushed a commit
to pudiva/dogstatsd-ruby
that referenced
this pull request
Jun 5, 2023
README: Update for re-org and remove extra info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted the internal API to be more friendly to the Ruby "principle of least surprise." I'd like to be able to pass a hash to
:tagswhen measuring things, instead of an array of strings delimited by a colon.This change allows a user to pass tags into the
.new()method as well as individual measurement methods.I created specs that test the outside interfaces, but I didn't add any for the internal, private method I created. I can create a couple of unit tests for that method if you'd like.