-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby cloud integration support #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
Some (maybe) naive questions here and there. Let's clean names as well so we are consistent within this SDK but also cross SDK. We should always have integration
when mentioning providers.
regarding your testing scenarios. I trust you so thay are as complete as possible 😄
@gzussa Thanks for the feedback here. I've updated the PR and this is ready for another look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this.
Adding support for the following endpoints:
AWS
AWS LOGS
AZURE ENDPOINTS
GCP ENDPOINTS
ORIGINAL PR was here: #190
I messed up the history of that one with a rebase, but fixed in this branch. Unfortunately the comments from @mattsp1290 and @zippolyte couldn't be transferred over but their comments were addressed here.