Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting keys in both query params and headers #194

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix setting keys in both query params and headers #194

merged 1 commit into from
Nov 7, 2019

Conversation

zippolyte
Copy link
Contributor

API would fail if we set both

gzussa
gzussa suggested changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add unit tests at least to make sure we don't reset both for relevant endpoints

gzussa
gzussa approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind my last comment

@zippolyte zippolyte merged commit 109f11c into master Nov 7, 2019
@zippolyte zippolyte deleted the hippo/ak branch November 7, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zippolyte @gzussa