add methods for missing hourly usage api endpoints #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the missing ruby methods for endpoints mentioned in open issue #137, specifically the
/usageendpoints for hosts, logs, custom metrics, traces, synthetics, and fargateget_[hosts,logs,custom_metrics,traces,synthetics,fargate]_usagemethods for /api/v1/usage/<hosts,logs,timeseries,traces,synthetics,fargate>PR notes
Did not include methods for
/usageendpoints get-top-500-custom-metrics-by-hourly-average and get-usage-across-your-multi-org-account as their formatting and general setup was a bit more complicated. Want to address these but probably a separate PR.The formatting/comments on all these method definitions are pretty similar, approach could be DRY'd up a bit if y'all prefer, following the structure of the rest of the repo I tried to keep everything explicit and separate
Anyways let me know what you think, happy to make any changes suggested, feedback welcome! Trying to make my way through the missing endpoints+methods when bandwidth permits.
~Eric