Add get_active_metrics and resolve_monitors methods for missing api endpoints #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the missing ruby methods for endpoints mentioned in open issue #137
Adds
get_active_metricsfor /api/v1/metricsAdds
resolve_monitorsfor /monitor/bulk_resolvePR notes
resolve_monitorsendpoint has a deprecated url format, so tried to format the method and the tests to be extensible for future compatibility if this gets moved under the/v1api umbrella.Anyways let me know what you think, happy to make any changes suggested, feedback welcome! Would like to tackle some of the other missing endpoints (usage/integrations/etc) when I have bandwidth but figured i'd try to get these out the door first.
~Eric