Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to call /integration endpoints #170

Merged
merged 3 commits into from
Mar 5, 2019

Conversation

davidcpell
Copy link
Contributor

We're working on some automation that requires keeping an integration with PagerDuty up-to-date. I was hoping someone might be able to give me feedback about where this change is on the right track.

I've been a bit confused while reading the API docs on integrations because of:

  • how the usage of POST and PUT is described
  • how that ^^ maps onto concepts like "adding" vs. replacing a configuration (specifically with POST)
  • how the fact that some integrations allow POST and others allow POST or PUT should factor into the design
  • and whether the resource we're acting on here is an "integration" or a "configuration" (and if the latter, whether integration : configuration is 1 : 1 or 1 : many)

@delner
Copy link

delner commented Mar 5, 2019

@athap Saw you had reviewed a previous PR that involved one of the files changed in this PR; is this something you could review? Or do you know someone who would be better suited?

@delner
Copy link

delner commented Mar 5, 2019

@gzussa You might want to look at this.

@delner
Copy link

delner commented Mar 5, 2019

@gmmeyer

Copy link

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @delner I took a look at this and it looks good to me. I'll just merge it!

@jeremy-lq
Copy link
Member

@davidcpell We'll have someone take a look today. Thanks for the contribution!

@gmmeyer gmmeyer merged commit 87b5e07 into DataDog:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants