[dashboards] Add support for the new Dashboard API #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLaureB
reviewed
Feb 1, 2019
enbashi
force-pushed
the
rami/add_new_dashboard_api
branch
from
35eaa11
to
62fa31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following endpoints for the new dashboard API:
create_board()=>POST /api/v1dashboard.update_board()=>PUT /api/v1dashboard/<dashboard_id>.get_board()=>GET /api/v1dashboard/<dashboard_id>.delete_board()=>DELETE /api/v1dashboard/<dashboard_id>.Notes:
timeboardsandscreenboardsAPIs.dashboardwas taken by the old timeboards API (eg:create_dashboard), I used the nameboard(eg:create_board). This might be confusing since internally I usedDashboardServiceto match our API naming/api/v1/dashboard, but I didn't want to introduce breaking changes.