Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the options as params to request #157

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Pass the options as params to request #157

merged 2 commits into from
Jun 5, 2019

Conversation

wonko
Copy link
Contributor

@wonko wonko commented Jun 25, 2018

The options var should be injected as extra_params, not as a body-content.

@wonko
Pass the options as params to request
b5da941 
The options var should be injected as extra_params, not as a body-content.
@wonko
Removes the pp requirement
506aefb 
The include statement installs https://rubygems.org/gems/pp/versions/0.1.1, which is not what we want...
@irabinovitch irabinovitch requested a review from gzussa May 7, 2019 04:43
@gzussa gzussa requested a review from a team June 5, 2019 13:30
gzussa
gzussa approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot for this fix! 😄

@gzussa gzussa merged commit eb4978c into DataDog:master Jun 5, 2019
@zippolyte zippolyte mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wonko @gzussa