Show more friendly error message with non JSON responses #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently encountered a situation where Datadog API server responded to a JSON API request with status code 500, which is perfectly fine, but the problem was that even though the request was sent as
Content-Type: application/jsonthe response from the API server wasContent-Type: text/htmlwith obviously a 500 error HTML as the body.I personally think when an error occurs while handling JSON request it should return error response in JSON format, indeed with
Content-Type: application/jsonas the request indicates, yet, this behavior strongly depends on how the API server is implemented, and is not something that client library should be aware of. That said, I think the current error message,"Invalid JSON Response"does not communicate well in such situation, and should show such errors with an error message that better describes what happened.