Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validate endpoint to dogapi-rb #127

Merged
merged 2 commits into from
May 1, 2017
Merged

Add validate endpoint to dogapi-rb #127

merged 2 commits into from
May 1, 2017

Conversation

isaacdd
Copy link
Contributor

@isaacdd isaacdd commented May 1, 2017

No description provided.

@isaacdd isaacdd requested a review from yannmh May 1, 2017 20:28
Copy link
Member

@degemer degemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add it there: https://github.com/DataDog/dogapi-rb/blob/master/lib/dogapi/facade.rb#L391-L425? (otherwise it's not exposed to the user)
LGTM apart from that.

@degemer degemer merged commit 9492b93 into master May 1, 2017
@degemer degemer deleted the validate_monitor branch May 1, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants