Allow additional options to be passed to monitor API calls #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog will occasionally add new parameters to their API. Instead of requiring a code change for each additional parameter, this change allows any additional option to be passed to the API.
|
Thanks for the contribution @jimmyngo ! I'll check later if we can do this in other parts of dogapi-rb. |
degemer
approved these changes
Apr 7, 2017
|
@degemer Thanks for merging this so quickly! Do you have an idea of when the next release might be? I'd love to use the official rubygem for this. |
|
@jimmyngo I'll try to release it in the next couple of weeks, feel free to ping me if it takes more than that! |
|
@jimmyngo 1.26.0 is out, feel free to start using it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datadog will occasionally add new parameters to their API. Instead of
requiring a code change for each additional parameter, this change
allows any additional option to be passed to the API.