Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CaptureIO delegation #114

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Fix CaptureIO delegation #114

merged 2 commits into from
Dec 13, 2016

Conversation

casperisfine
Copy link

SSHKit try to call tty? on the output instance to know if it can send ANSI color codes.

This PR fix the way CaptureIO does delegation, so that SSHKit isn't wrongly told that the output isn't a TTY.

@casperisfine
Copy link
Author

I also pushed a second commit that fixes the output with capistrano >= 3.5.0:

Before:
capture d ecran 2016-11-14 a 10 51 30

After:
capture d ecran 2016-11-14 a 10 52 27

@degemer degemer self-assigned this Dec 12, 2016
@degemer degemer added this to the 1.24.0 milestone Dec 12, 2016
@degemer
Copy link
Member

degemer commented Dec 12, 2016

Thank you @casperisfine for your contribution ! I'll have a look at your changes soon (later this week).

degemer
degemer approved these changes Dec 13, 2016
View reviewed changes
Copy link
Member

@degemer degemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, LGTM, will be part of the next release.

@degemer degemer merged commit 599daf6 into DataDog:master Dec 13, 2016
@casperisfine
Copy link
Author

Awesome, thanks!

@goldenson goldenson deleted the fix-delegation branch January 9, 2019 17:31
@swalkinshaw swalkinshaw restored the fix-delegation branch January 9, 2019 18:36
@gmcgibbon gmcgibbon deleted the fix-delegation branch January 15, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degemer degemer degemer approved these changes

Assignees

@degemer degemer

Labels
None yet
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@casperisfine @degemer @byroot