-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASM] Skip DefaultInterpolatedStringHandler
flaky tests
#6379
base: master
Are you sure you want to change the base?
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6379) - mean (69ms) : 66, 72
. : milestone, 69,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6379) - mean (981ms) : 950, 1012
. : milestone, 981,
master - mean (983ms) : 961, 1006
. : milestone, 983,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6379) - mean (108ms) : 104, 112
. : milestone, 108,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6379) - mean (679ms) : 662, 697
. : milestone, 679,
master - mean (681ms) : 663, 699
. : milestone, 681,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6379) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 88, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6379) - mean (634ms) : 619, 650
. : milestone, 634,
master - mean (632ms) : 619, 645
. : milestone, 632,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6379) - mean (191ms) : 187, 195
. : milestone, 191,
master - mean (190ms) : 185, 195
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6379) - mean (1,092ms) : 1068, 1117
. : milestone, 1092,
master - mean (1,090ms) : 1058, 1122
. : milestone, 1090,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6379) - mean (277ms) : 273, 282
. : milestone, 277,
master - mean (275ms) : 270, 281
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (6379) - mean (867ms) : 841, 894
. : milestone, 867,
master - mean (869ms) : 844, 894
. : milestone, 869,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6379) - mean (266ms) : 262, 270
. : milestone, 266,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6379) - mean (852ms) : 821, 883
. : milestone, 852,
master - mean (847ms) : 817, 878
. : milestone, 847,
|
Datadog ReportBranch report: ✅ 0 Failed, 449005 Passed, 2748 Skipped, 19h 11m 30.14s Total Time |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6379) (11.234M) : 0, 11234493
master (11.170M) : 0, 11169702
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6379) (7.311M) : 0, 7310722
master (7.238M) : 0, 7238344
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.615M) : 0, 7614718
section Manual
master (11.243M) : 0, 11243170
section Manual + Automatic
This PR (6379) (6.846M) : 0, 6845969
master (6.802M) : 0, 6802395
section DD_TRACE_ENABLED=0
master (10.227M) : 0, 10227352
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6379) (9.482M) : 0, 9481847
master (9.506M) : 0, 9506267
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6379) (6.425M) : 0, 6424761
master (6.170M) : 0, 6169845
section Trace stats
master (6.647M) : 0, 6646897
section Manual
master (9.555M) : 0, 9555067
section Manual + Automatic
This PR (6379) (5.805M) : 0, 5804575
master (5.888M) : 0, 5887876
section DD_TRACE_ENABLED=0
master (8.842M) : 0, 8841869
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6379) (9.946M) : 0, 9945667
master (9.305M) : 0, 9305411
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6379) (6.663M) : 0, 6663027
master (6.079M) : 0, 6078552
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.809M) : 0, 6808501
section Manual
master (9.573M) : 0, 9573245
section Manual + Automatic
This PR (6379) (5.999M) : 0, 5998678
master (5.806M) : 0, 5805727
section DD_TRACE_ENABLED=0
master (8.890M) : 0, 8890110
|
Benchmarks Report for tracer 🐌Benchmarks for #6379 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations
|
Benchmark | Base Allocated | Diff Allocated | Change | Change % |
---|---|---|---|---|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.5 KB | 41.71 KB | 215 B | 0.52% |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | WriteAndFlushEnrichedTraces |
net6.0 | 541μs | 2.72μs | 12.8μs | 0.532 | 0 | 0 | 41.5 KB |
master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 759μs | 4.26μs | 30.7μs | 0.379 | 0 | 0 | 41.73 KB |
master | WriteAndFlushEnrichedTraces |
net472 | 864μs | 4.24μs | 18.5μs | 8.36 | 2.64 | 0.44 | 53.28 KB |
#6379 | WriteAndFlushEnrichedTraces |
net6.0 | 592μs | 3.18μs | 18.5μs | 0.563 | 0 | 0 | 41.71 KB |
#6379 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 681μs | 2.67μs | 10μs | 0.331 | 0 | 0 | 41.73 KB |
#6379 | WriteAndFlushEnrichedTraces |
net472 | 873μs | 4.36μs | 19.5μs | 8.81 | 2.52 | 0.419 | 53.31 KB |
Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6379
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0
1.123
1,208.56
1,356.82
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.123 | 1,208.56 | 1,356.82 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteNonQuery |
net6.0 | 1.21μs | 1.42ns | 5.51ns | 0.0145 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
netcoreapp3.1 | 1.79μs | 1.2ns | 4.63ns | 0.0144 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
net472 | 1.95μs | 1.61ns | 6.01ns | 0.157 | 0.000979 | 0 | 987 B |
#6379 | ExecuteNonQuery |
net6.0 | 1.36μs | 1.8ns | 6.98ns | 0.0143 | 0 | 0 | 1.02 KB |
#6379 | ExecuteNonQuery |
netcoreapp3.1 | 1.72μs | 1.79ns | 6.7ns | 0.0138 | 0 | 0 | 1.02 KB |
#6379 | ExecuteNonQuery |
net472 | 2.16μs | 2.59ns | 9.68ns | 0.157 | 0.00107 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.14μs | 2.25ns | 8.41ns | 0.0136 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.54μs | 0.751ns | 2.91ns | 0.0131 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.44μs | 2.49ns | 8.98ns | 0.157 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.22μs | 0.398ns | 1.49ns | 0.0134 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.68μs | 0.58ns | 2.17ns | 0.0135 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.54μs | 0.491ns | 1.84ns | 0.167 | 0 | 0 | 1.05 KB |
#6379 | CallElasticsearch |
net6.0 | 1.24μs | 0.53ns | 2.05ns | 0.0136 | 0 | 0 | 976 B |
#6379 | CallElasticsearch |
netcoreapp3.1 | 1.55μs | 1.11ns | 4.31ns | 0.0132 | 0 | 0 | 976 B |
#6379 | CallElasticsearch |
net472 | 2.52μs | 1.57ns | 6.07ns | 0.157 | 0 | 0 | 995 B |
#6379 | CallElasticsearchAsync |
net6.0 | 1.21μs | 0.752ns | 2.91ns | 0.0134 | 0 | 0 | 952 B |
#6379 | CallElasticsearchAsync |
netcoreapp3.1 | 1.65μs | 1.27ns | 4.58ns | 0.0139 | 0 | 0 | 1.02 KB |
#6379 | CallElasticsearchAsync |
net472 | 2.69μs | 0.641ns | 2.31ns | 0.166 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.22μs | 0.477ns | 1.78ns | 0.0135 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.72μs | 1.48ns | 5.33ns | 0.013 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.8μs | 1.32ns | 5.09ns | 0.145 | 0 | 0 | 915 B |
#6379 | ExecuteAsync |
net6.0 | 1.26μs | 0.391ns | 1.41ns | 0.0132 | 0 | 0 | 952 B |
#6379 | ExecuteAsync |
netcoreapp3.1 | 1.63μs | 0.726ns | 2.62ns | 0.0128 | 0 | 0 | 952 B |
#6379 | ExecuteAsync |
net472 | 1.79μs | 0.544ns | 1.96ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.32μs | 1.81ns | 7.03ns | 0.0326 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.26μs | 1.85ns | 6.93ns | 0.0369 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.33μs | 1.52ns | 5.88ns | 0.496 | 0 | 0 | 3.12 KB |
#6379 | SendAsync |
net6.0 | 4.34μs | 2.56ns | 9.9ns | 0.0324 | 0 | 0 | 2.31 KB |
#6379 | SendAsync |
netcoreapp3.1 | 5.35μs | 1.9ns | 7.35ns | 0.0372 | 0 | 0 | 2.85 KB |
#6379 | SendAsync |
net472 | 7.28μs | 1.54ns | 5.78ns | 0.494 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.45μs | 0.775ns | 2.79ns | 0.0232 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.21μs | 0.803ns | 3.11ns | 0.022 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.51μs | 0.932ns | 3.61ns | 0.249 | 0 | 0 | 1.57 KB |
#6379 | EnrichedLog |
net6.0 | 1.5μs | 0.63ns | 2.36ns | 0.0229 | 0 | 0 | 1.64 KB |
#6379 | EnrichedLog |
netcoreapp3.1 | 2.2μs | 2.09ns | 8.1ns | 0.0221 | 0 | 0 | 1.64 KB |
#6379 | EnrichedLog |
net472 | 2.64μs | 1.19ns | 4.61ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 120μs | 96.9ns | 375ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 125μs | 114ns | 441ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 152μs | 72.3ns | 280ns | 0.686 | 0.229 | 0 | 4.46 KB |
#6379 | EnrichedLog |
net6.0 | 120μs | 130ns | 488ns | 0.0604 | 0 | 0 | 4.28 KB |
#6379 | EnrichedLog |
netcoreapp3.1 | 125μs | 118ns | 455ns | 0 | 0 | 0 | 4.28 KB |
#6379 | EnrichedLog |
net472 | 152μs | 123ns | 478ns | 0.633 | 0.158 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.04μs | 1.05ns | 3.93ns | 0.031 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.33μs | 1.05ns | 3.93ns | 0.0299 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.84μs | 1.87ns | 7.24ns | 0.32 | 0 | 0 | 2.02 KB |
#6379 | EnrichedLog |
net6.0 | 3.01μs | 0.904ns | 3.5ns | 0.0306 | 0 | 0 | 2.2 KB |
#6379 | EnrichedLog |
netcoreapp3.1 | 4.06μs | 1.56ns | 6.06ns | 0.0304 | 0 | 0 | 2.2 KB |
#6379 | EnrichedLog |
net472 | 4.83μs | 2.14ns | 8.3ns | 0.319 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.36μs | 0.443ns | 1.66ns | 0.0163 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.81μs | 0.726ns | 2.81ns | 0.0156 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 1.99μs | 2.37ns | 9.19ns | 0.183 | 0 | 0 | 1.16 KB |
#6379 | SendReceive |
net6.0 | 1.32μs | 0.762ns | 2.95ns | 0.0159 | 0 | 0 | 1.14 KB |
#6379 | SendReceive |
netcoreapp3.1 | 1.84μs | 1.13ns | 4.21ns | 0.0156 | 0 | 0 | 1.14 KB |
#6379 | SendReceive |
net472 | 2.07μs | 1.14ns | 4.43ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.75μs | 2.96ns | 11.1ns | 0.0219 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.94μs | 1.63ns | 6.31ns | 0.0218 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.42μs | 1.73ns | 6.72ns | 0.322 | 0 | 0 | 2.04 KB |
#6379 | EnrichedLog |
net6.0 | 2.75μs | 0.852ns | 3.07ns | 0.022 | 0 | 0 | 1.6 KB |
#6379 | EnrichedLog |
netcoreapp3.1 | 3.86μs | 1.54ns | 5.98ns | 0.0213 | 0 | 0 | 1.65 KB |
#6379 | EnrichedLog |
net472 | 4.54μs | 1.94ns | 7.53ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 403ns | 0.472ns | 1.83ns | 0.00817 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 585ns | 0.612ns | 2.29ns | 0.00777 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 721ns | 1.6ns | 6.21ns | 0.0915 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 513ns | 0.599ns | 2.32ns | 0.00977 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 686ns | 1.26ns | 4.89ns | 0.00928 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 873ns | 1.75ns | 6.77ns | 0.105 | 0 | 0 | 658 B |
#6379 | StartFinishSpan |
net6.0 | 391ns | 0.587ns | 2.27ns | 0.00805 | 0 | 0 | 576 B |
#6379 | StartFinishSpan |
netcoreapp3.1 | 603ns | 1.06ns | 4.09ns | 0.00768 | 0 | 0 | 576 B |
#6379 | StartFinishSpan |
net472 | 708ns | 1.59ns | 6.14ns | 0.0917 | 0 | 0 | 578 B |
#6379 | StartFinishScope |
net6.0 | 556ns | 0.605ns | 2.34ns | 0.00966 | 0 | 0 | 696 B |
#6379 | StartFinishScope |
netcoreapp3.1 | 669ns | 1.29ns | 5ns | 0.0094 | 0 | 0 | 696 B |
#6379 | StartFinishScope |
net472 | 871ns | 1.31ns | 5.07ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6379
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.134
584.36
662.78
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.134 | 584.36 | 662.78 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 584ns | 0.775ns | 3ns | 0.00963 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 838ns | 1.27ns | 4.92ns | 0.0093 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.13μs | 2.28ns | 8.83ns | 0.105 | 0 | 0 | 658 B |
#6379 | RunOnMethodBegin |
net6.0 | 662ns | 0.875ns | 3.15ns | 0.0097 | 0 | 0 | 696 B |
#6379 | RunOnMethodBegin |
netcoreapp3.1 | 890ns | 2.48ns | 9.6ns | 0.00955 | 0 | 0 | 696 B |
#6379 | RunOnMethodBegin |
net472 | 1.07μs | 1.74ns | 6.75ns | 0.104 | 0 | 0 | 658 B |
Summary of changes
Skip
DefaultInterpolatedStringHandler
flaky implicit unit tests.Reason for change
Flakiness.