Remove settings snapshot generator #6370

andrewlock · 2024-11-28T16:01:33Z

Summary of changes

Delete the tracer settings snapshot source generator
Delete the snapshot objects

Reason for change

We used these for tracking when customers use config in code so we know which properties they're changing. However, in v3 we explicitly set the values ourselves in the ConfigureIntegration so we may as well do all the work there

Implementation details

Delete the source generator
Delete usages of [GenerateSnapshot], [IgnoreForSnapshot], and [ConfigKey]
Delete TracerSettingsSnapshot and associated files and usages
Record config changes in ConfigureIntegration

Test coverage

Added a simple basic assertion to the manual instrumentation tests to assert that we're still recording the code origin

Other details

This is step 1 of a whole load of post-v3 code cleanup 😄

Remove old generated public APIs #6376
Remove settings snapshot generator #6370 👈 this PR

datadog-ddstaging · 2024-11-28T16:23:28Z

Datadog Report

Branch report: andrew/remove-snapshot-generation
Commit report: cee1ebb
Test service: dd-trace-dotnet

❌ 1 Failed (0 Known Flaky), 453838 Passed, 2776 Skipped, 19h 1m 52.41s Total Time

❌ Failed Tests (1)

HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Details

Expand for error

 
 Expected collection to contain a single item matching x.IsRequestType("app-closing"), but no such item was found.rate a span, but found False.lse.

andrewlock · 2024-11-28T16:35:12Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6370) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6370) - mean (971ms)  : 945, 998
     .   : milestone, 971,
    master - mean (983ms)  : 961, 1006
     .   : milestone, 983,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6370) - mean (107ms)  : 105, 110
     .   : milestone, 107,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6370) - mean (675ms)  : 655, 696
     .   : milestone, 675,
    master - mean (681ms)  : 663, 699
     .   : milestone, 681,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6370) - mean (91ms)  : 90, 93
     .   : milestone, 91,
    master - mean (91ms)  : 88, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6370) - mean (623ms)  : 606, 640
     .   : milestone, 623,
    master - mean (632ms)  : 619, 645
     .   : milestone, 632,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6370) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6370) - mean (1,085ms)  : 1059, 1111
     .   : milestone, 1085,
    master - mean (1,090ms)  : 1058, 1122
     .   : milestone, 1090,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6370) - mean (276ms)  : 271, 282
     .   : milestone, 276,
    master - mean (275ms)  : 270, 281
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6370) - mean (867ms)  : 829, 904
     .   : milestone, 867,
    master - mean (869ms)  : 844, 894
     .   : milestone, 869,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6370) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6370) - mean (841ms)  : 805, 876
     .   : milestone, 841,
    master - mean (847ms)  : 817, 878
     .   : milestone, 847,

andrewlock · 2024-11-28T17:17:28Z

Benchmarks Report for tracer 🐌

Benchmarks for #6370 compared to master:

1 benchmarks are faster, with geometric mean 1.194
3 benchmarks are slower, with geometric mean 1.156
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.98μs	44.9ns	287ns	0.0159	0.00398	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	51.1ns	234ns	0.02	0.00998	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	45.8ns	177ns	1.08	0.34	0.113	6.21 KB
#6370	`StartStopWithChild`	net6.0	8.11μs	45.9ns	308ns	0.0117	0.00777	0	5.61 KB
#6370	`StartStopWithChild`	netcoreapp3.1	10.4μs	55.2ns	297ns	0.0201	0.01	0	5.8 KB
#6370	`StartStopWithChild`	net472	16.4μs	63.3ns	237ns	1.04	0.296	0.0881	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	491μs	434ns	1.68μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	665μs	521ns	2.02μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	848μs	289ns	1.04μs	0.422	3.3 KB
#6370	`WriteAndFlushEnrichedTraces`	net6.0	482μs	378ns	1.46μs	0	2.7 KB
#6370	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	572ns	2.06μs	0	2.7 KB
#6370	`WriteAndFlushEnrichedTraces`	net472	845μs	457ns	1.71μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	150μs	865ns	7.29μs	0.147	14.47 KB
master	`SendRequest`	netcoreapp3.1	172μs	1.05μs	10.4μs	0.166	17.27 KB
master	`SendRequest`	net472	0.00145ns	0.000771ns	0.00299ns	0	0 b
#6370	`SendRequest`	net6.0	150μs	809ns	5.66μs	0.141	14.47 KB
#6370	`SendRequest`	netcoreapp3.1	162μs	931ns	7.33μs	0.159	17.27 KB
#6370	`SendRequest`	net472	0.00408ns	0.00114ns	0.00442ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6370

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.5 KB	41.79 KB	290 B	0.70%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	541μs	2.72μs	12.8μs	0.532	0	0	41.5 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	759μs	4.26μs	30.7μs	0.379	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	net472	864μs	4.24μs	18.5μs	8.36	2.64	0.44	53.28 KB
#6370	`WriteAndFlushEnrichedTraces`	net6.0	573μs	2.62μs	11.7μs	0.548	0	0	41.79 KB
#6370	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	672μs	3.64μs	19.6μs	0.332	0	0	41.83 KB
#6370	`WriteAndFlushEnrichedTraces`	net472	881μs	4.32μs	17.3μs	8.3	2.62	0.437	53.31 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.21μs	1.42ns	5.51ns	0.0145	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.2ns	4.63ns	0.0144	0	1.02 KB
master	`ExecuteNonQuery`	net472	1.95μs	1.61ns	6.01ns	0.157	0.000979	987 B
#6370	`ExecuteNonQuery`	net6.0	1.28μs	0.963ns	3.73ns	0.0146	0	1.02 KB
#6370	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	3.07ns	11.9ns	0.0133	0	1.02 KB
#6370	`ExecuteNonQuery`	net472	2.06μs	1.4ns	5.42ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6370

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.162	1,140.80	1,325.50

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.14μs	2.25ns	8.41ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.751ns	2.91ns	0.0131	976 B
master	`CallElasticsearch`	net472	2.44μs	2.49ns	8.98ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.22μs	0.398ns	1.49ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.58ns	2.17ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.54μs	0.491ns	1.84ns	0.167	1.05 KB
#6370	`CallElasticsearch`	net6.0	1.33μs	0.378ns	1.42ns	0.0135	976 B
#6370	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.711ns	2.46ns	0.0134	976 B
#6370	`CallElasticsearch`	net472	2.59μs	1.4ns	5.44ns	0.157	995 B
#6370	`CallElasticsearchAsync`	net6.0	1.35μs	0.552ns	2.06ns	0.0134	952 B
#6370	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.27ns	4.75ns	0.0135	1.02 KB
#6370	`CallElasticsearchAsync`	net472	2.71μs	1.36ns	5.28ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.22μs	0.477ns	1.78ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.72μs	1.48ns	5.33ns	0.013	952 B
master	`ExecuteAsync`	net472	1.8μs	1.32ns	5.09ns	0.145	915 B
#6370	`ExecuteAsync`	net6.0	1.3μs	1.52ns	5.69ns	0.013	952 B
#6370	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.931ns	3.48ns	0.0128	952 B
#6370	`ExecuteAsync`	net472	1.83μs	1.92ns	7.43ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.32μs	1.81ns	7.03ns	0.0326	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.26μs	1.85ns	6.93ns	0.0369	2.85 KB
master	`SendAsync`	net472	7.33μs	1.52ns	5.88ns	0.496	3.12 KB
#6370	`SendAsync`	net6.0	4.38μs	1.42ns	5.49ns	0.033	2.31 KB
#6370	`SendAsync`	netcoreapp3.1	5.32μs	2.7ns	10.1ns	0.0373	2.85 KB
#6370	`SendAsync`	net472	7.2μs	1.92ns	7.42ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	0.775ns	2.79ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	0.803ns	3.11ns	0.022	1.64 KB
master	`EnrichedLog`	net472	2.51μs	0.932ns	3.61ns	0.249	1.57 KB
#6370	`EnrichedLog`	net6.0	1.47μs	1.68ns	6.51ns	0.0231	1.64 KB
#6370	`EnrichedLog`	netcoreapp3.1	2.17μs	0.992ns	3.71ns	0.0217	1.64 KB
#6370	`EnrichedLog`	net472	2.54μs	0.98ns	3.8ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	96.9ns	375ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	125μs	114ns	441ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	72.3ns	280ns	0.686	0.229	4.46 KB
#6370	`EnrichedLog`	net6.0	118μs	245ns	949ns	0.0602	0	4.28 KB
#6370	`EnrichedLog`	netcoreapp3.1	123μs	125ns	486ns	0	0	4.28 KB
#6370	`EnrichedLog`	net472	151μs	181ns	653ns	0.678	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.04μs	1.05ns	3.93ns	0.031	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.33μs	1.05ns	3.93ns	0.0299	2.2 KB
master	`EnrichedLog`	net472	4.84μs	1.87ns	7.24ns	0.32	2.02 KB
#6370	`EnrichedLog`	net6.0	3.09μs	0.803ns	3.01ns	0.0309	2.2 KB
#6370	`EnrichedLog`	netcoreapp3.1	4.22μs	1.98ns	7.67ns	0.0296	2.2 KB
#6370	`EnrichedLog`	net472	4.79μs	1.27ns	4.93ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6370

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.114	1,360.79	1,515.96

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.36μs	0.443ns	1.66ns	0.0163	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	0.726ns	2.81ns	0.0156	1.14 KB
master	`SendReceive`	net472	1.99μs	2.37ns	9.19ns	0.183	1.16 KB
#6370	`SendReceive`	net6.0	1.52μs	0.718ns	2.78ns	0.0158	1.14 KB
#6370	`SendReceive`	netcoreapp3.1	1.76μs	1.32ns	5.12ns	0.015	1.14 KB
#6370	`SendReceive`	net472	2.02μs	1.94ns	7.51ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.75μs	2.96ns	11.1ns	0.0219	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.94μs	1.63ns	6.31ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.42μs	1.73ns	6.72ns	0.322	2.04 KB
#6370	`EnrichedLog`	net6.0	2.74μs	2.64ns	10.2ns	0.0218	1.6 KB
#6370	`EnrichedLog`	netcoreapp3.1	3.83μs	1.86ns	7.21ns	0.0211	1.65 KB
#6370	`EnrichedLog`	net472	4.44μs	1.73ns	6.47ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6370

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.194	722.03	604.64

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	403ns	0.472ns	1.83ns	0.00817	576 B
master	`StartFinishSpan`	netcoreapp3.1	585ns	0.612ns	2.29ns	0.00777	576 B
master	`StartFinishSpan`	net472	721ns	1.6ns	6.21ns	0.0915	578 B
master	`StartFinishScope`	net6.0	513ns	0.599ns	2.32ns	0.00977	696 B
master	`StartFinishScope`	netcoreapp3.1	686ns	1.26ns	4.89ns	0.00928	696 B
master	`StartFinishScope`	net472	873ns	1.75ns	6.77ns	0.105	658 B
#6370	`StartFinishSpan`	net6.0	442ns	0.812ns	3.15ns	0.00799	576 B
#6370	`StartFinishSpan`	netcoreapp3.1	637ns	3.42ns	18.1ns	0.0078	576 B
#6370	`StartFinishSpan`	net472	605ns	0.717ns	2.87ns	0.0917	578 B
#6370	`StartFinishScope`	net6.0	535ns	0.786ns	3.04ns	0.00986	696 B
#6370	`StartFinishScope`	netcoreapp3.1	672ns	0.881ns	3.41ns	0.00944	696 B
#6370	`StartFinishScope`	net472	848ns	2.03ns	7.86ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6370

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.193	584.36	696.97

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	584ns	0.775ns	3ns	0.00963	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	838ns	1.27ns	4.92ns	0.0093	696 B
master	`RunOnMethodBegin`	net472	1.13μs	2.28ns	8.83ns	0.105	658 B
#6370	`RunOnMethodBegin`	net6.0	697ns	0.881ns	3.41ns	0.00969	696 B
#6370	`RunOnMethodBegin`	netcoreapp3.1	908ns	1.67ns	6.46ns	0.00933	696 B
#6370	`RunOnMethodBegin`	net472	1.17μs	2.38ns	9.21ns	0.104	658 B

andrewlock · 2024-11-28T20:42:23Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6370) (11.236M)   : 0, 11236317
    master (10.950M)   : 0, 10950268
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6370) (7.340M)   : 0, 7340058
    master (7.144M)   : 0, 7144062
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.592M)   : 0, 7592116

    section Manual
    master (11.151M)   : 0, 11151368

    section Manual + Automatic
    This PR (6370) (6.742M)   : 0, 6741997
    master (6.721M)   : 0, 6721227

    section DD_TRACE_ENABLED=0
    master (10.133M)   : 0, 10132646

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6370) (9.540M)   : 0, 9539831
    master (9.581M)   : 0, 9581060
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6370) (6.377M)   : 0, 6376931
    master (6.411M)   : 0, 6411077

    section Trace stats
    master (6.557M)   : 0, 6557433

    section Manual
    master (9.539M)   : 0, 9539314

    section Manual + Automatic
    This PR (6370) (5.770M)   : 0, 5770420
    master (5.854M)   : 0, 5854294

    section DD_TRACE_ENABLED=0
    master (8.891M)   : 0, 8890821

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6370) (9.874M)   : 0, 9874127
    master (10.194M)   : 0, 10193580
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6370) (6.266M)   : crit ,0, 6266172
    master (6.769M)   : 0, 6768819
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.357M)   : 0, 7356753

    section Manual
    master (10.447M)   : 0, 10447376

    section Manual + Automatic
    This PR (6370) (5.758M)   : 0, 5758009
    master (5.985M)   : 0, 5985300

    section DD_TRACE_ENABLED=0
    master (9.475M)   : 0, 9475300

kevingosse

I like when code is deleted

…correctly

andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:cleanup Minor code clean up area:telemetry labels Nov 28, 2024

andrewlock requested review from a team as code owners November 28, 2024 16:01

andrewlock marked this pull request as draft November 28, 2024 17:12

andrewlock force-pushed the andrew/remove-snapshot-generation branch from 8a618f7 to b2e414e Compare November 29, 2024 10:17

andrewlock marked this pull request as ready for review November 29, 2024 10:18

andrewlock requested a review from a team as a code owner November 29, 2024 10:18

kevingosse approved these changes Nov 29, 2024

View reviewed changes

andrewlock added 3 commits November 29, 2024 13:38

Remove snapshot generator

c4ddbed

Ensure we record the configuration in telemetry when it's set

522072d

Add integration test to check that we record "code" telemetry config …

a9bea3f

…correctly

andrewlock force-pushed the andrew/remove-snapshot-generation branch from b2e414e to a9bea3f Compare November 29, 2024 13:40

tonyredondo approved these changes Nov 29, 2024

View reviewed changes

andrewlock mentioned this pull request Nov 29, 2024

Remove old generated public APIs #6376

Open

Remove tests that will no longer reply

cee1ebb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove settings snapshot generator #6370

Remove settings snapshot generator #6370

andrewlock commented Nov 28, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 28, 2024 •

edited

Loading

andrewlock commented Nov 28, 2024 •

edited

Loading

andrewlock commented Nov 28, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #6370

Raw results

Raw results

Slower ⚠️ in #6370

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6370

Raw results

Raw results

Faster 🎉 in #6370

Raw results

Slower ⚠️ in #6370

Raw results

andrewlock commented Nov 28, 2024 •

edited

Loading

kevingosse left a comment

Remove settings snapshot generator #6370

Are you sure you want to change the base?

Remove settings snapshot generator #6370

Conversation

andrewlock commented Nov 28, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Nov 28, 2024 • edited Loading

Datadog Report

❌ Failed Tests (1)

andrewlock commented Nov 28, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 28, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6370

Raw results

Raw results

Slower ⚠️ in #6370

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6370

Raw results

Raw results

Faster 🎉 in #6370

Raw results

Slower ⚠️ in #6370

Raw results

andrewlock commented Nov 28, 2024 • edited Loading

Throughput/Crank Report ⚡

kevingosse left a comment

Choose a reason for hiding this comment

andrewlock commented Nov 28, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 28, 2024 •

edited

Loading

andrewlock commented Nov 28, 2024 •

edited

Loading

andrewlock commented Nov 28, 2024 •

edited

Loading

andrewlock commented Nov 28, 2024 •

edited

Loading