You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This library is used by ingress-nginx, which uses nginx-opentracing to load the plugin, and ingress-nginx generates a JSON file to configure the tracer.
Most settings are supported via JSON, but some newer ones are not.
The reason during development was because they affect a different path in the codebase - its internal WritingSpanBuffer - and the target during development didn't load config via JSON.
The inconsistency has affected a developer that wanted to add these new features to ingress-nginx as options the user can set, because it couldn't add them to the generated JSON to set them.
While there are other ways to make it work, it's hard to explain to users and is a bit hacky.
This library is used by ingress-nginx, which uses nginx-opentracing to load the plugin, and ingress-nginx generates a JSON file to configure the tracer.
Most settings are supported via JSON, but some newer ones are not.
The reason during development was because they affect a different path in the codebase - its internal
WritingSpanBuffer
- and the target during development didn't load config via JSON.The inconsistency has affected a developer that wanted to add these new features to ingress-nginx as options the user can set, because it couldn't add them to the generated JSON to set them.
While there are other ways to make it work, it's hard to explain to users and is a bit hacky.
Related:
The text was updated successfully, but these errors were encountered: