Postgres: Handle negative replication delay #977
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the master and slave's clocks are slightly out of sync, and there is virtually no replication delay, we may experience that a negative timedelta in the replication delay check. That is however not detected in the current code, as Python sets the
days
property to-1
andseconds
to86400
, in order to not have a negative number in theseconds
property.This change checks if
days
is a negative number, and if it is, we always send 0 seconds as the replication delay.There's an example of how it can look if it isn't fixed here: