rework AD image name extractor to support new swarm format #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/sd_image_ident
branch
2 times, most recently
from
3d48892 to
cb96a65
Compare
hkaj
reviewed
Sep 8, 2017
tests/core/test_service_discovery.py
Outdated
| # Custom registry, simple form | ||
| 'myregistry.local:5000/testing/test-image:version': 'test-image', | ||
| # Customm regustry, most insane for possible | ||
| 'myregistry.local:5000/testing/test-image:version@sha256:5bef08742407efd622d243692b79ba0055383bbce12900324f75e56f589aedb0': 'test-image', |
swarm can use org/image:tag@sha256:xxxxxxxx format, that throws off the parser. reworking it to handle all known formats and unit test it
xvello
force-pushed
the
xvello/sd_image_ident
branch
from
cb96a65 to
768b364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swarm can use org/image:tag@sha256:xxxxxxxx format, that throws off
the parser. reworking it to handle all known formats and unit test it
Testing Guidelines
Added
test_get_image_identunit test