[core][cloud_metadata] Use Metadata-Flavor header to avoid request exception for GCE tags #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We get the following log when we start the dd-agent on an instance in GCE.
dd.collector | utils.cloud_metadata(cloud_metadata.py:45) | Collecting GCE Metadata failed Header value True must be of type str or bytes, not <type 'bool'>It looks like the header in the request sent to GCE to get the metadata is in the wrong format. Also I think this is now deprecated in favour of
Metadata-Flavor: Google(see https://cloud.google.com/compute/docs/metadata#transitioning)This PR uses the new
Metadata-Flavor: GoogleMotivation
We're relying on GCE tags to identify important groups of instances and none of these tags are coming through.