[core] add a DNS cache #3197
Merged
[core] add a DNS cache #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
commented
Feb 15, 2017
| @@ -209,6 +212,8 @@ def __sizeof__(self): | |||
|
|
|||
| def get_url(self, endpoint, api_key): | |||
| endpoint_base_url = get_url_endpoint(endpoint) | |||
| if self._application.agent_dns_caching: | |||
| endpoint_base_url = self._application.get_from_dns_cache(endpoint_base_url) | |||
There was a problem hiding this comment.
This could mess up the SSL/TLS verification, which is domain name based. This sort of DNS caching would therefore require making the requests with verify=False. Big issue because it would open the door to man-in-the-middle attacks. That said, that option already exists in the agent.
[core][tests] further test fixes.
truthbk
force-pushed
the
jaime/dnscache
branch
from
de4fd8f to
5ac2145
Compare
|
Should we document the option in |
degemer
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a DNS cache to the agent, if disabled the agent just skips any local DNS resolution. Otherwise we've implemented a very simple cache that should allow us to reduce the number of DNS queries made.
Motivation
A customer was complaining about too many DNS queries. We suggested some local caching like
dnsmasq, apparently that was not an option for them. Unfortunately there was no way to do this usingrequests, which was the preferred approach.Testing Guidelines
An overview on testing
is available in our contribution guidelines.