[collector][emitter] Ignore all non-unicode-decodable characters #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen cases (on Japanese and Korean versions of Windows) where the json encoding would fail on a UnicodeDecodeError because of non-utf8-decodable characters in strings. To work around this, when this happens, we make another pass on the whole payload to remove all the non-decodable characters and log the affected strings.
gmmeyer
approved these changes
Oct 20, 2016
|
Basically, when So events with non-roman characters should be fine as long as they're utf8-decodable. @gmmeyer Let me know if that's clear enough for you, if so I'll merge this :) |
|
Yes, merge this if you feel it's ready! I was just curious what the outcome would be. |
|
Ok, thanks @gmmeyer! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On Japanese and Korean versions of Windows, We've seen cases where
the json encoding would fail on a UnicodeDecodeError because of
non-utf8-decodable characters in strings, which causes the whole emitter to fail.
This fixes the issue by making another pass on the
whole payload to remove all the non-decodable characters and log the
affected strings.
Testing Guidelines
Added a mock test on the function that removes non-decodable chars.