[dev mode] fallback to /tmp to dump pstats #2934
Conversation
There was a problem hiding this comment.
Why not always dump it in a tempfile.mkstemp ? (https://docs.python.org/2/library/tempfile.html#tempfile.mkstemp)
Something like
file_handle, file_path = tempfile.mkstemp(prefix='collector-statsd-', suffix='.dmp')
file_handle.close()
ps.dump_stats(file_path)Since the path is in the debug log anyway.
But it'd be quite annoying when running in foreground. Try the current directory and then dump in a temp directory ?
At least don't hardcode /tmp, tempfile.gettempdir() is there for this. 📁
| log.debug("Pstats dumps are enabled. Dumping pstats output to {0}".format(self.STATS_DUMP_FILE)) | ||
| except IOError: | ||
| log.debug('Dumping pstats output to {} failed, using /tmp instead.'.format(self.STATS_DUMP_FILE)) | ||
| ps.dump_stats(urljoin('/tmp/', self.STATS_DUMP_FILE)) |
hkaj
force-pushed
the
haissam/dev-mode-fix-dump
branch
from
4b1e6c6 to
60b0b64
Compare
|
thanks for the review @degemer |
| self.collector_profile_interval = self._agentConfig.get('collector_profile_interval', | ||
| DEFAULT_COLLECTOR_PROFILE_INTERVAL) | ||
| try: | ||
| self.collector_profile_interval = int(self._agentConfig.get('collector_profile_interval')) |
There was a problem hiding this comment.
The default is still needed in the get, otherwise it will always fail when not configured.
| DEFAULT_COLLECTOR_PROFILE_INTERVAL) | ||
| try: | ||
| self.collector_profile_interval = int(self._agentConfig.get('collector_profile_interval')) | ||
| except ValueError: |
There was a problem hiding this comment.
I think it's a TypeError: TypeError: int() argument must be a string or a number, not 'NoneType'.
hkaj
force-pushed
the
haissam/dev-mode-fix-dump
branch
from
60b0b64 to
02f0220
Compare
hkaj
force-pushed
the
haissam/dev-mode-fix-dump
branch
from
02f0220 to
a32e81b
Compare
|
doh! I added the default back. The exception is a |
What does this PR do?
If dumping pstats in the current dir fails, fall back to /tmp.
Motivation
User noticed that they didn't get the dumps because the agent was trying to write to
/as the default path is relative and they were probably running it with supervisor.Additional Notes
This was just a minor bug as the agent should not run in dev mode in production (it ruins its perf) and usually runs in the foreground from a directory where it has write access.