[service discovery] fix fallback IP address extraction #2855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
When no key (network name or id) was passed to the
host
variable, we used to skip the_get_fallback_ip
method and only try using theConfig.NetworkSettings.IPAddress
address (which is empty more often than not now). With this PR,_get_fallback_ip
applies every time, using thebridge
network address or the last network (sorted) address.Motivation
More and more often
Config.NetworkSettings.IPAddress
is empty, relying on it makes the agent fail in cases where it could infer the config automatically.Testing Guidelines
Updated the relevant mocks in unit tests
Additional Notes
split('_')
to 1 to avoid splitting the specifier if it has a_
.