Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] check considers docker daemon as a container on old docker versions #2841

Closed
hkaj opened this issue Sep 13, 2016 · 1 comment
Closed

Comments

@hkaj
Copy link
Member

hkaj commented Sep 13, 2016

this only affects older docker versions

In older docker versions /proc/$DOCKER_DAEMON_PID/cgroup looks like

10:net_prio:/docker-daemon
9:perf_event:/docker-daemon
8:blkio:/docker-daemon
7:net_cls:/docker-daemon
6:freezer:/docker-daemon
5:devices:/docker-daemon
4:memory:/docker-daemon
3:cpuacct:/docker-daemon
2:cpu:/docker-daemon
1:cpuset:/docker-daemon

In the code we consider the process as a container if 'docker' in line[2] here: https://github.com/DataDog/dd-agent/blob/5.8.5/checks.d/docker_daemon.py#L807

Recent versions are not affected since the lines look like i:whatever:/, without the matching docker string.

This was discovered on a docker daemon version 1.9.1 and does not exist in 1.11 so it should affect few people but should still be fixed.

@hkaj
Copy link
Member Author

hkaj commented Sep 15, 2016

Fixed by #2847

@hkaj hkaj closed this as completed Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant