[core] avoid calls to service discovery from dogstatsd #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
changed the title
hkaj
force-pushed
the
haissam/dogstatsd-sd-issue
branch
from
5d9727d to
4bc1b22
Compare
|
CI failures are unrelated (timeouts) |
|
LGTM! |
|
thanks @olivielpeau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dogstatsd calls util.get_hostname that in turn was making calls to service discovery related code. This PR remove this behavior.
Motivation
Although it was just calling the constructor of the config store class as a side effect, it's better to keep things separated.
Testing Guidelines
We should make sure the hostname is still resolved the same way to avoid breaking things. This was tested locally with and without docker and the results are satisfying.
Additional Notes
🙈