Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redisdb] Avoid exception when slowlog query returns empty command #2651

Merged
merged 1 commit into from
Jul 5, 2016

Conversation

olivielpeau
Copy link
Member

The command field can be empty with the current version of redis-py
querying a custom "Garantia Data" Redis version.

In this case, and until redis-py adds support for it, we just send the
histogram without the command tag, which is better than nothing.

Fixes #2629

Thanks @fotinakis for reporting this issue!

The `command` field can be empty with the current version of redis-py
querying a custom "Garantia Data" Redis version.

In this case, and until redis-py adds support for it, we just send the
histogram without the `command` tag, which is better than nothing.
@yannmh
Copy link
Member

yannmh commented Jul 5, 2016

:shipit:

@olivielpeau
Copy link
Member Author

Thanks @yannmh! Merging

@olivielpeau olivielpeau merged commit e161bca into master Jul 5, 2016
@olivielpeau olivielpeau deleted the olivielpeau/workaround-custom-redis-slowlog branch July 5, 2016 17:59
truthbk pushed a commit that referenced this pull request Aug 10, 2016
…2651)

The `command` field can be empty with the current version of redis-py
querying a custom "Garantia Data" Redis version.

In this case, and until redis-py adds support for it, we just send the
histogram without the `command` tag, which is better than nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants