[util] remove LaconicFilter #2605
Conversation
|
Wholly agree with your reasons to remove the filter! Went through the checks that are currently using the filter to check that they wouldn't start flooding the logs, and IMO there are 2 places, in
Apart from this the PR looks good to me! 🚀 |
|
While we are at it, it could be useful to increase the max logging size: As sometimes when investigating issues, logs already got rotated. |
degemer
force-pushed
the
quentin/delete-laconic
branch
from
d9ef1ba to
77e3933
Compare
|
Updated as per your comments. I guess |
|
Yeah... The custom dogstream parsers that log a lot could start flooding the collector logs, but I still think it's better to remove the filter. Should be up to the custom parsers' implementations to log things responsibly IMO... |
degemer
force-pushed
the
quentin/delete-laconic
branch
from
77e3933 to
22b9caf
Compare
| self.logger.exception("Cannot parse %s", proc_meminfo) | ||
| parse_error = True | ||
| if parse_error: | ||
| self.logger.error("Error parsing %s", proc_meminfo) |
There was a problem hiding this comment.
this line is over-indented 😛
|
Had one nitpick, feel free to merge once it's fixed! 🎆 |
This filter might be sometimes useful, but it:
- complexifies debug when you don't know it exists ("What don't I see
this line multiple times in the logs"),
- adds a lot of noise when trying to track memory utilization,
- is completely unexpected.
This also muzzle two noisy log lines.
degemer
force-pushed
the
quentin/delete-laconic
branch
from
22b9caf to
d8cb076
Compare
|
Thanks for the review, waiting for the 💚 CI before merging. |
Since we removed the LaconicFilter (see #2605) the collector is filled with `Running check xxxx` messages. Let's log it at the `info` level only on the first run (since it can be useful to quickly detect if a check is consistently running too slowly), but only log it at the `debug` level afterwards.
Since we removed the LaconicFilter (see #2605) the collector is filled with `Running check xxxx` messages. Let's log it at the `info` level only on the first run (since it can be useful to quickly detect if a check is consistently running too slowly), but only log it at the `debug` level afterwards.
…ly (#2772) * [collector][logging] Log check starts with info level on first run only Since we removed the LaconicFilter (see #2605) the collector is filled with `Running check xxxx` messages. Let's log it at the `info` level only on the first run (since it can be useful to quickly detect if a check is consistently running too slowly), but only log it at the `debug` level afterwards.
This filter may be useful, but it:
this line multiple times in the logs"),