Use local var for container_name #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes
```
2016-05-04 05:24:24 UTC | ERROR | dd.collector | checks.docker_daemon(__init__.py:763) | Check 'docker_daemon' instance #0 failed
Traceback (most recent call last):
File "/opt/datadog-agent/agent/checks/__init__.py", line 746, in run
self.check(copy.deepcopy(instance))
File "/opt/datadog-agent/agent/checks.d/docker_daemon.py", line 222, in check
containers_by_id = self._get_and_count_containers()
File "/opt/datadog-agent/agent/checks.d/docker_daemon.py", line 273, in _get_and_count_containers
self._filter_containers(containers)
File "/opt/datadog-agent/agent/checks.d/docker_daemon.py", line 412, in _filter_containers
self.log.debug("Container {0} is filtered".format(container["Names"][0]))
IndexError: list index out of range
```
when trying to exclude containers from monitoring
|
Looks good to me. Good catch @yenif and thanks for providing a fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
when trying to exclude containers from monitoring