[IIS] Deal with BytesTransfered vs BytesTransferred 2008sp2 typo #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
changed the title
| @@ -87,6 +95,10 @@ def check(self, instance): | |||
| filters=filters, instance_tags=instance_tags | |||
| ) | |||
| ) | |||
| except pythoncom.com_error: | |||
There was a problem hiding this comment.
We could be a little bit more specific here and log a warning only when the error string contains the error code that we expect, i.e.:
except pythoncom.com_error as e:
if '0x80041017' in str(e):
self.warning("blah blah")
raise eAlso, we could use self.warning instead of self.log.warning.
Thoughts?
|
@truthbk Added in a few comments. Looks good overall! |
[iis] just change properties to query when it corresponds. [iis] adding note to config yaml.
|
Let's |
!
|
(the CI failures are unrelated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to address the crazy typo made in windows 2008 IIS (not sure if it's IIS or windows version specific).
Also updated the tests to cover this scenario.