Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Add a default timeout parameter to retrieve_json #2345

Merged
merged 1 commit into from
Mar 11, 2016

Conversation

hkaj
Copy link
Member

@hkaj hkaj commented Mar 11, 2016

Add a timeout to avoid hanging requests that get the collector killed.

@hkaj hkaj added wontfix and removed wontfix labels Mar 11, 2016
@hkaj hkaj force-pushed the haissam/retrieve-json-default-timeout branch from 8a4b4cb to 15efe5e Compare March 11, 2016 09:07
@remh
Copy link

remh commented Mar 11, 2016

👍

hkaj added a commit that referenced this pull request Mar 11, 2016
…imeout

[utils] Add a default timeout parameter to retrieve_json
@hkaj hkaj merged commit 00594ef into master Mar 11, 2016
@hkaj hkaj deleted the haissam/retrieve-json-default-timeout branch March 11, 2016 10:15
@olivielpeau olivielpeau added this to the 5.8.0 milestone Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants