[wmi] add tag_by to the properties to collect
#2296
Merged
+74
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,7 +42,7 @@ def check(self, instance): | |||
|
|
|||
| wmi_sampler = self._get_wmi_sampler( | |||
| instance_key, | |||
| wmi_class, properties, | |||
| wmi_class, properties, tag_by, | |||
There was a problem hiding this comment.
Nitpick: I prefer naming the parameter explicitely when it's an optional parameter, so tag_by=tag_by here :)
Append `tag_by` property to the list of properties to collect.
yannmh
force-pushed
the
yann/wmi-add-tag_by-to_properties
branch
from
b09f9e4 to
6aa4de4
Compare
|
👍 |
olivielpeau
added a commit
that referenced
this pull request
Feb 26, 2016
[wmi] add `tag_by` to the properties to collect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append
tag_byproperty to the list of properties to collect.