Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snmp] fix situation when ont requested oid is prefix for another requested oid #2246

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

xkrt
Copy link
Contributor

@xkrt xkrt commented Feb 3, 2016

I was faced with the following situation, my simplified conf:

metrics:
  - OID: 1.2.3
    name: first
  - OID: 1.2.3.4.5
    name: second

As you see OID of first is prefix of second OID. Without my bug fix both metrics get the value of first (since second have prefix 1.2.3).

@xkrt
Copy link
Contributor Author

xkrt commented Feb 4, 2016

/сс @bunelr @truthbk @yannmh

@yannmh yannmh added this to the 5.7.0 milestone Feb 4, 2016
@yannmh yannmh added the bugfix label Feb 4, 2016
@yannmh
Copy link
Member

yannmh commented Feb 4, 2016

That's certainly an issue, thanks a lot for fixing it @xkrt !
We'll review and merge your fix for the upcoming 5.7.0 release.

@yannmh yannmh self-assigned this Feb 4, 2016
@yannmh
Copy link
Member

yannmh commented Feb 5, 2016

Looks great @xkrt. Would you mind squashing your commits so we can merge your contribution ?

Thanks again.

@xkrt
Copy link
Contributor Author

xkrt commented Feb 7, 2016

@yannmh done

@yannmh
Copy link
Member

yannmh commented Feb 8, 2016

Thanks. Let's merge it 🚢

yannmh added a commit that referenced this pull request Feb 8, 2016
[snmp] fix situation when ont requested oid is prefix for another requested oid
@yannmh yannmh merged commit 19c5006 into DataDog:master Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants