Add timeout for requests to get go expvar metrics. #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gphat |
|
Excellent, thanks! |
|
Merging, the failing tests are related to this issue #2187 |
remh
pushed a commit
that referenced
this pull request
Jan 7, 2016
Add timeout for requests to get go expvar metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a timeout for requests made to fetch go expvar metrics.
Motivation
Locally we had a misbehaving app that never answered, causing the entire collector to be blocked and not getting metrics!
Notes
Should this be configurable?
r? @antifuchs @remh