[consul] more accurate nodes_* and services_* gauges #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so it is now checking the serfHealth for each service node. Also track the actual status of the nodes in the service.
talwai
added a commit
that referenced
this pull request
Dec 7, 2015
[consul] more accurate nodes_* and services_* gauges
|
Ya, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and slightly modified version of #2018 . It queries for cluster status via the
/v1/health/service/<service>endpoint, which allows us to split the coarse-grainedconsul.catalog.nodes_upandconsul.catalog.services_upmetrics into the followingconsul.catalog.nodes_passingtagged byconsul_service_idconsul.catalog.nodes_warningtagged byconsul_service_idconsul.catalog.nodes_criticaltagged byconsul_service_idconsul.catalog.services_passingtagged byconsul_node_idconsul.catalog.services_warningtagged byconsul_node_idconsul.catalog.services_criticaltagged byconsul_node_idThe
consul.catalog.nodes_upandconsul.catalog.services_upmetrics are preserved with their original values, but will likely be removed or renamed in a future version of the check.Additionally
consul.checkservice checks are now tagged byconsul_service_idrather thanservice-idto keep consistent with theconsul.catalog.*tagging schemeTODOs:
consul.catalog.services_*functionalitycc @mtougeron