[postgres] FIX: pg8000 wasn't doing a good job with multiple relations #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Customer confirmed fix is working for them 😄 |
| @@ -437,10 +437,10 @@ def _collect_stats(self, key, db, instance_tags, relations, custom_metrics): | |||
| try: | |||
| # if this is a relation-specific query, we need to list all relations last | |||
| if scope['relation'] and len(relations) > 0: | |||
| relnames = relations_config.keys() | |||
| relnames = ', '.join("'{0}'".format(w) for w in relations_config.keys()) | |||
There was a problem hiding this comment.
nitpick but you can use iterkeys instead of keys
…s in list. [postgres] another query to fix. [postgres] use iterkeys() to iterate more efficiently.
truthbk
force-pushed
the
jaime/postgres-fix
branch
from
a48a078 to
8ec3d4a
Compare
|
As per @remh comments, switching to iterkeys() for dict iteration. |
|
LGTM! |
truthbk
added a commit
that referenced
this pull request
Dec 7, 2015
[postgres] FIX: pg8000 wasn't doing a good job with multiple relations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer was having issues with the postgres check, after investigating it became apparent that metrics weren't reported for all specified relations. It looks like pg8000 wasn't doing a good job with the parameter substitution when making executing the SQL query.
The fix consists in having us build the query manually instead.