[windows][requests] Bundle default CA certs of requests
#2098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py2exe only includes the python files of the python packages in the
library
zipped file. This causes therequests
library to be shippedwithout CA certs, so all the https requests made with it fail (unless
SSL cert validation is explicitely disabled).
This fixes the issue by:
requests
with the Windowsagent as an extra data file
requests
uses(which is done in quite an ugly way, but I haven't found any better
way)
Notes:
tornado
, but to be as close as possible to the agent's behavior on other platforms I've used the default CA certs provided byrequests
/certifi
http_check
on Windows, because the check uses default paths that are only valid on unix platforms: seedd-agent/checks.d/http_check.py
Lines 127 to 131 in 8fed4c9